Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaokai/0.1.3 #55

Merged
merged 43 commits into from
Aug 12, 2024
Merged

Shaokai/0.1.3 #55

merged 43 commits into from
Aug 12, 2024

Conversation

yeshaokai
Copy link
Collaborator

Fixed a bug

Changed hardcoded paths to relative paths in demo notebooks

@MMathisLab
Copy link
Member

MMathisLab commented Aug 8, 2024

I guess once residents report more bugs, I can do one more commit push tomorrow and then we can merge.

README.md Outdated
@@ -36,7 +36,7 @@ In our original work (NeurIPS 2023) we used GPT3.5 and GPT4 as part of our agent
Conda is an easy-to-use Python interface that supports launching [Jupyter Notebooks](https://jupyter.org/). If you are completely new to this, we recommend checking out the [docs here for getting conda installed](https://deeplabcut.github.io/DeepLabCut/docs/beginner-guides/beginners-guide.html#beginner-user-guide). Otherwise, proceed to use one of [our supplied conda files](https://github.com/AdaptiveMotorControlLab/AmadeusGPT/tree/main/conda). As you will see we have minimal dependencies to get started, and [here is a simple step-by-step guide](https://deeplabcut.github.io/DeepLabCut/docs/installation.html#step-2-build-an-env-using-our-conda-file) you can reference for setting it up (or see [BONUS](README.md#bonus---customized-your-conda-env) below). Here is the quick start command:

```bash
conda env create -f amadeusGPT.yml
conda env create -f conda/amadeusGPT.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please drop conda; that is not useful is one downloads the file, for example.

Copy link
Collaborator Author

@yeshaokai yeshaokai Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why it keeps coming back actually... I remember I had it removed too. Though Marc told me he was confused why conda/ was not there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if one is within the conda/ folder this cannot be run either, so it's best to keep it not there and use that Q as an opportunity to educate :D

notebooks/EPM_demo.ipynb Show resolved Hide resolved
@yeshaokai
Copy link
Collaborator Author

@MMathisLab Some improvements based on how residents used it. This can be 0.1.3.

@MMathisLab MMathisLab changed the title Shaokai/0.1.2 patch Shaokai/0.1.3 Aug 12, 2024
@MMathisLab MMathisLab self-requested a review August 12, 2024 13:45
@MMathisLab MMathisLab merged commit cf27b78 into main Aug 12, 2024
4 checks passed
@MMathisLab MMathisLab deleted the shaokai/0.1.2_patch branch August 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants