Initial support for style module media query variations #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding support for media query variations on style modules.
I put this in a feature branch so @khamudom can implement the high contrast styles.
Issues
Closes #89
Reviewer Notes
It was straightforward to add this functionality to
Styles
. I wanted to supportBehavior
closer, butStyles
is intended to be an abstraction for it to work with tooling and other non-FASTElement components. This is potentially a grey area as hooking ontoStyles
provides a good place to do this, if it still makes sense that not everything conveyed inStyles
is applicable for every potential output (like Figma).Test Plan
We will need a full test pass of all components in Storybook.
Checklist
General
Component-specific
⏭ Next Steps
Continue defining the forced colors high contrast styles.