Added support for disabled state colors #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added
disabled
state to the interactive color model.Removed the fixed 30% opacity temporary styling.
Added a Palette for disabled state, defaulting to neutral, which removes the color from accent or highlight components, an additional signal of the disabled state.
Migrated most of the
not-allowed
cursor support to a global style module. There's something I'd still like to cleanup here regarding components where the whole component should appear disabled vs. only the child elements. This depends on how the empty space works in the components - A list or menu item (full component) compared to an input field with label (more of an "L" shape).Issues
Closes #91
Related to #79
Reviewer Notes
This feels like a pretty solid update to me, but there are a couple of things I'd still like to cleanup.
black-or-white
recipe, which could migrate to another recipe since black and white are at the extents of all palettes. I want to think about this more, so for now I shimmed a reasonable default solution.Test Plan
Tested in Explorer and Storybook.
Checklist
General
Component-specific
⏭ Next Steps
I found that Slider is not going disabled, but that's happening aside from these changes. Will address separately (#150).