Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for disabled state colors #151

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

bheston
Copy link
Member

@bheston bheston commented Oct 15, 2023

Pull Request

Description

image

Added disabled state to the interactive color model.
Removed the fixed 30% opacity temporary styling.
Added a Palette for disabled state, defaulting to neutral, which removes the color from accent or highlight components, an additional signal of the disabled state.
Migrated most of the not-allowed cursor support to a global style module. There's something I'd still like to cleanup here regarding components where the whole component should appear disabled vs. only the child elements. This depends on how the empty space works in the components - A list or menu item (full component) compared to an input field with label (more of an "L" shape).

Issues

Closes #91
Related to #79

Reviewer Notes

This feels like a pretty solid update to me, but there are a couple of things I'd still like to cleanup.

  • One is the cursor issue mentioned above.
  • Another is the black-or-white recipe, which could migrate to another recipe since black and white are at the extents of all palettes. I want to think about this more, so for now I shimmed a reasonable default solution.

Test Plan

Tested in Explorer and Storybook.

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

I found that Slider is not going disabled, but that's happening aside from these changes. Will address separately (#150).

- Added deltas to base semantic recipes
- Added a disabled palette to enable neutral disabled states
- Added support for global styles
- Added disabled cursor to global styles
- Added support for disabled state in the Explorer app
Copy link
Contributor

@awentzel awentzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean to me. But, I sent Nate Brown a link to take a look as you want someone that's always in the code to provide feedback. Thanks for keeping things moving.

@bheston bheston merged commit f9e8704 into main Oct 17, 2023
2 checks passed
@bheston bheston deleted the users/bheston/adaptive-ui-disabled-state branch October 17, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add disabled styling support to style modules
3 participants