Complete SeeMore Project -- NinjaParty #10
Conversation
…ing on sessions#delete tests
…lled change to Twitter API calls.
| @people.sort_by! { |person| person.username.downcase } | ||
|
|
||
| @feed = [] | ||
| @people.each do |person| |
There was a problem hiding this comment.
A brief review of your code shows that you're not using this @people variable in the index view (though you are using a @people in the people action). So, first thought is that this does not need to be an instance variable. Second that is that the sort_by! block on line 17 is unnecessary, as you sort again on line 24. The sort on @feed makes sense to me as that's what you're outputting on the page. Sorting can be really expensive, so please take a moment to figure out if it's really necessary.
|
Great start here. Please review as a group when you can and send me a slack message after. I'd like to ask a couple of followup questions. Thanks! |
instagram_posts#create and instagram feed
…ore into ninjaparty/master
…ore into fun-secret/edm
…ore into ninjaparty/master
|
@sallyamoore @elsamoluf @wangg131 @acmei Ok, #21 merged in your first week code, so this PR is just second week now. Please update title and description when you're done with changes. |
Refactor and fixing specs.
Revert "Refactor and fixing specs."
… reverted refactor I did earlier b/c I thought it might be breaking stuff.
…mers_controller_spec.
…ore into ninjaparty/master
acmei
changed the title
We are in the process of displaying feeds. Right now, the instagram feed displays as a giant hash of recent instagram posts and the twitter feed displays as a giant list of tweets. We haven't combined them, and we have been working in pairs on them. As a result, you'll see in the feeds#index method that there are two chunks of code doing things that potentially conflict. Ignore the feeds#index or look at it as if only one of the
if @user &&...blocks exists.We use the twitter gem (but not the instagram one).
It's going well! :)
Thu Aug 13: Final PR
We finished the project requirements a couple days early and then spent the rest of the time getting tests to pass (using VCR for API calls), some refactoring, and then fixing tons of bugs caused by refactoring. We prevented app users from being able to follow the same social media account twice, disabled dev login on production, and made all instagram and twitter posts links to the actual posts online.
http://ninjaparty.herokuapp.com/