Amethyst - Jay King, Hannah Watkins, Raina Campbell #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to facts-branch
…to facts-branch
Facts branch
moved styling to style.css
flex the facts
fix links in index
…to facts-branch
jayriverking
changed the title
ameerrah9
reviewed
Jun 10, 2023
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+29
to
+35
| nav ul li { | ||
| display: inline-block; | ||
| font-size: 25px; | ||
| width: 25%; | ||
| background-color: pink; | ||
| margin: auto; | ||
| } |
There was a problem hiding this comment.
Nice work using this descendant selector, typically we name folders that hold css files "styles"
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+9
to
+23
| header { | ||
| background-color: #2893a1; | ||
| color: #fff; | ||
| padding: 10px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| nav ul { | ||
| list-style-type: none; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| nav li { | ||
| display: inline-block; |
There was a problem hiding this comment.
To make reading easy and avoid possible confusion, I suggest keeping all CSS rules at the same indentation level.
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+17
to
+28
| <header> | ||
| <nav> | ||
| <ul> | ||
| <li><a href="index.html">Home</a></li> | ||
| <li><a href="facts.html">Fun Facts</a></li> | ||
| <li><a href="gallery.html">Gallery</a></li> | ||
| </ul> | ||
| </nav> | ||
| </header> | ||
| <section> | ||
| <article> | ||
| <h1>Fun Facts About...</h1> |
There was a problem hiding this comment.
It's a little subjective, but in this layout I might consider the header and the section as part of the significant content of the page and place it inside a main tag.
ameerrah9
reviewed
Jun 10, 2023
Comment on lines
+39
to
+51
| <img src="fun-fact-imgs/hunter.jpeg" alt="hunter x hunter"> | ||
| <p>Hisoka's appearance as a clown, hairstyle, painted teardrops, card throwing skills, etc., may be references to another Yoshihiro Togashi character, Suzuki, from his earlier work YuYu Hakusho, when he was dressed up as a clown. Hisoka changes his appearances at each turn of the story arc.</p> | ||
| </li> | ||
|
|
||
| <li><h4>UP</h4> | ||
| <img src="fun-fact-imgs/kevin.png" alt="Kevin, a giant fictional bird from the animated movie Up"> | ||
| <p>Fun Fact: Many sources, including Peter Docter's study guide to Up and even the movie, say that Kevin's species is the mythical "Snipe", a fictional bird created to send foolish people on wild goose chases. <br><br> In reality, a snipe is a kind of wading bird which has a long slender bill and brown patterned plumage. | ||
| </p> | ||
| </li> | ||
|
|
||
| <li><h4>Inside Out</h4> | ||
| <img src="fun-fact-imgs/inside-out.webp" alt="inside out"> | ||
| <p>The writers initially intended to include an antagonist named Gloom. The early scripts would have Gloom try to bring everyone down and destroy Riley’s island. |
There was a problem hiding this comment.
Really nice semantic HTML across the page!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.