Jessie-Anh-Mikayla group fansite project #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikayla - Home page
…shows up in tab for all pages
There was a problem hiding this comment.
Group Fansite
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | ✅ |
| Appropriate Git Usage | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
✅ |
| All images include alternate text | ✅ |
| No validation errors | ✅ |
| CSS | |
| Using class and ID names in style declarations | ✅ |
| Style declarations are DRY | 😞 |
| Uses Flexbox or Grid | ✅ |
| Overall | 💯 |
Comment on lines
+1
to
+31
| .topnav { | ||
| background-color: #333; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| /* Style the links inside the navigation bar */ | ||
| .topnav a { | ||
| float: left; | ||
| color: #f2f2f2; | ||
| text-align: center; | ||
| padding: 14px 16px; | ||
| text-decoration: none; | ||
| font-size: 17px; | ||
| } | ||
|
|
||
| /* Change the color of links on hover */ | ||
| .topnav a:hover { | ||
| background-color: #ddd; | ||
| color: black; | ||
| } | ||
|
|
||
| /* Add a color to the active/current link */ | ||
| .topnav a.active { | ||
| background-color: #c21792; | ||
| color: white; | ||
| } | ||
|
|
||
| /* Right-aligned section inside the top navigation */ | ||
| .topnav-right { | ||
| float: right; | ||
| } |
There was a problem hiding this comment.
All of these are defined in the style.css file and do not need to be defined here since the page imports both stylesheets. This applies to the other CSS files as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.