Skip to content

Commit

Permalink
Update ruby version. Add pronto eslint runner. (#14)
Browse files Browse the repository at this point in the history
* Bump ruby version to 2.6. Add missing erb_lint runner. Add new eslint_npm runner.

* Freeze eslint version to 6.8.0

* Use buster slim ruby image as base image
  • Loading branch information
Saicheg authored Mar 24, 2020
1 parent 77e3c0e commit f7610fe
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 6 deletions.
18 changes: 13 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,27 +1,35 @@
FROM ruby:2.5
FROM ruby:2.6-slim

LABEL maintainer="Josh Bielick <[email protected]>"

ENV BUNDLER_VERSION="2.1.4"
ENV ESLINT_VERSION="6.8.0"

RUN apt-get update && apt-get install -y curl
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -

RUN apt-get update && \
apt-get install -y \
bash \
ruby-dev \
build-essential \
cmake \
git \
pkg-config \
openssl \
yamllint \
nodejs \
&& rm -rf /var/lib/apt/lists/*

RUN gem install bundler
RUN gem install bundler --version "${BUNDLER_VERSION}"
RUN npm install -g eslint@${ESLINT_VERSION}

WORKDIR /runner

COPY Gemfile* ./

ENV BUNDLE_GEMFILE /runner/Gemfile
RUN bundle --retry 4

RUN bundle --jobs 2 --retry 4
ENV BUNDLE_GEMFILE /runner/Gemfile

COPY . ./

Expand Down
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ gem 'pronto', '~> 0.10'
gem 'pronto-rubocop', '~> 0.10'
gem 'pronto-brakeman', '~> 0.10'
gem 'pronto-bundler_audit', '~> 0.6'
gem 'pronto-eslint_npm', '~> 0.10'
gem 'pronto-rails_best_practices', '~> 0.10'
gem 'pronto-rails_schema', '~> 0.10'
gem 'pronto-rails_data_schema', '~> 0.1'
Expand Down
5 changes: 4 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ GEM
pronto-erb_lint (0.1.5)
erb_lint (~> 0.0.24)
pronto (> 0.9.0)
pronto-eslint_npm (0.10.1)
pronto (~> 0.10.0)
pronto-fasterer (0.10.0)
fasterer (~> 0.3, >= 0.3.0)
pronto (~> 0.10.0)
Expand Down Expand Up @@ -259,6 +261,7 @@ DEPENDENCIES
pronto-brakeman (~> 0.10)
pronto-bundler_audit (~> 0.6)
pronto-erb_lint (~> 0.1)
pronto-eslint_npm (~> 0.10)
pronto-fasterer (~> 0.10)
pronto-flay (~> 0.10)
pronto-poper (~> 0.10)
Expand All @@ -282,4 +285,4 @@ DEPENDENCIES
webmock

BUNDLED WITH
2.1.2
2.1.4
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ The docker image of this Action includes the following [Pronto Runners](https://

- brakeman
- bundler_audit
- eslint_npm
- fasterer
- flay
- poper
Expand Down

0 comments on commit f7610fe

Please sign in to comment.