Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes & GoDoc Descriptions #291

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

rmenn
Copy link
Contributor

@rmenn rmenn commented Dec 10, 2014

Fixed a couple of bugs that i myself created.
Added Description for godoc
Added VpcId to Create Security Group so that SGs can be created within VPC.

Please Review.

Thanks

@rmenn
Copy link
Contributor Author

rmenn commented Dec 10, 2014

If all Good, Can close #135

@alimoeeny
Copy link
Contributor

Thanks @rmenn
Does it make sense to keep the signature for CreateSecurityGroup intact and add another function like CreateSecurityGroupInVPC
Although we don't have a guideline for this, I feel uncomfortable about this. and "traditionally" people have added functionality by keeping the old functions and adding new ones.
Soon we need to sit down and plan a next major release and cleanup all of these.

@rmenn
Copy link
Contributor Author

rmenn commented Dec 11, 2014

Makes Sense, Let me redo that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants