Support b and i tags in Basic HTML #4
Conversation
There was a problem hiding this comment.
Why has the package platform been bumped to 16? It should continue supporting the lowest possible version.
There was a problem hiding this comment.
Because it was failing to compile on iOS. macOS was compiling fine.
The Regex at BasicHTML.swift:96 & 98 seems to be the culprit.
../BasicHTML.swift:96:37: 'Regex' is only available in iOS 16.0 or newer
../BasicHTML.swift:96:54: 'firstMatch(in:)' is only available in iOS 16.0 or newer
../BasicHTML.swift:98:42: 'output' is only available in iOS 16.0 or newer
I think it would have been passing the checks because the build is done on macOS 13.
There was a problem hiding this comment.
That makes sense, I'll push another merge after this to fix the platforms for macOS. As for this or it looks good!
There was a problem hiding this comment.
Now worries. macOS seems ok as Regex exists in macOS 13.
Is there anything you want me to change?
|
Thank you for the PR! I just have on comment about the package version, other than that it looks great :) |
The
<b>and<i>tags are still quite common. This PR adds support for them to the BasicHTML parser.