Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2857040#: Only use successful payments for EOD calculation and … #16

Open
wants to merge 1 commit into
base: 7.x-2.x
Choose a base branch
from
Open

Issue 2857040#: Only use successful payments for EOD calculation and … #16

wants to merge 1 commit into from

Conversation

MattBred
Copy link
Contributor

@MattBred MattBred commented Mar 13, 2017

…make sure payments show up as VOID under reports

The Journal Report will now show the void payments crossed out, just like the receipts.

pos_voidpayments_1

The fixed calculations.

pos_voidpayments_2

The Sale page now shows the cash crossed out just like the receipt and report page.

pos_voidpayments_3

…make sure payments show up as VOID under reports
@smmccabe
Copy link
Member

Talked w/ Jason and Matt F about the UX for the last section as I found the strike-throughts to be a so-so at conveying the void. We came up with a simpler solution that should clean this page up a bit.

  • Drop the icons entirely
  • Remove strikethrough
  • replace the struck-through total on a void with just the word VOID
  • remove Void from next to cache
  • move the "void" link from floating in the middle to underneath the dollar amount, remember to keep it spaced out and big enough to work on mobile/touch

@travis-bradbury
Copy link

Jason did a little mock-up because I need to be able to display a transaction ID for payments as well.

Void link appears on the left, not under the amount.
image

This change is related to displaying the transaction number but is a separate issue.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants