Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommercePosTransactionBaseActions.php #14

Open
wants to merge 1 commit into
base: 7.x-2.x
Choose a base branch
from

Conversation

yurg
Copy link

@yurg yurg commented Feb 21, 2017

  Have faced this one https://www.drupal.org/node/2824865  It's closed as "Works as designed", yet still affects operations at our side, 
  because taxes are being added twice in certain circumstances.   It seems, commenting out commerce_tax_calculate_by_type fixes issue in our case,  yet it's not quite clear if there are any side effects, caused by code change.  We observe no issues so far, doesn't mean there aren't any.  It seems the piece of code may be obsolete, yet not 100% sure.

      Have faced this one https://www.drupal.org/node/2824865  It's closed as "Works as designed", yet still affects operations at our side, 
      because taxes are being added twice in certain circumstances.   It seems, commenting out commerce_tax_calculate_by_type fixes issue in our case,  yet it's not quite clear if there are any side effects, caused by code change.  We observe no issues so far, doesn't mean there aren't any.  It seems the piece of code may be obsolete, yet not 100% sure.
@thejacer87
Copy link

@yurg I just implemented checked the issue on DO and applied your fix. There is an issue though, although it might not matter to you.

What I've found so far is that you won't get a breakdown of prices in the total column.

With your fix:
image

Without fix:
image

So just keep us informed if you run into any other issues with it. We're still not sure if it's a commerce issue or a POS issue.

@yurg
Copy link
Author

yurg commented Feb 22, 2017

@thejacer87 Thank you for note; we're aware of prices breakdown disappearance, it's an acceptable trade-off, since we don't need it for a moment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants