Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added install state for better update of plugins (#1026) #1058

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Added install state for better update of plugins (#1026) #1058

merged 1 commit into from
Oct 20, 2024

Conversation

alMukaafih
Copy link
Contributor

@alMukaafih alMukaafih commented Oct 20, 2024 •
edited
Loading

Fix for #1026

@bajrangCoder
Copy link
Collaborator

Theoretically it seems correct, have you tested?

@bajrangCoder bajrangCoder merged commit 9cb0012 into Acode-Foundation:main Oct 20, 2024
2 checks passed
@alMukaafih alMukaafih deleted the plugin-installer-enhancement branch October 20, 2024 15:19
@bajrangCoder
Copy link
Collaborator

I found a bug. When installing some plugins locally it fails with no any error logs , just shows a toast.
You can reproduce it by building this plugin and try it by installing locally.

https://github.com/bajrangCoder/MarkdownCompiler

bajrangCoder added a commit that referenced this pull request Oct 28, 2024
@bajrangCoder
Revert "Added install state for better update of plugins (#1058)"
778da27 
This reverts commit 9cb0012.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajrangCoder bajrangCoder bajrangCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alMukaafih @bajrangCoder