Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Dependencies #1030

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

alMukaafih
Copy link
Contributor

No description provided.

@bajrangCoder
Copy link
Collaborator

bajrangCoder commented Sep 10, 2024

have you tested it? It doesn't work.
You need to properly handle the paid plugin cases etc

@alMukaafih
Copy link
Contributor Author

alMukaafih commented Oct 13, 2024

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

@bajrangCoder
Copy link
Collaborator

I have tested it and it works for both free and paid plugins though further testing is needed for paid plugins

Now it's working fine.
Just one thing left:
It should show the name of plugin which is installing in loader and also before installing the dependencies it's nice to show the user that it's going to install these plugins too.

@bajrangCoder bajrangCoder self-assigned this Oct 14, 2024
@bajrangCoder bajrangCoder added enhancement New feature or request plugin api It represents, plugins specific apis enhancement labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs info / awaiting response plugin api It represents, plugins specific apis enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants