add dd trace #851
Merged
add dd trace #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
removed legacy dd codes, and added dd trace to 2 levels of calls:
eth_xxx)For now almost all second levels calls are tracked, just to collect more comprehensive info, and to confirm everything has expected performance.
If these trackings increase cost, we can gradually refine tracking to most essential methods. We can also add more tags to group essential methods
Test
dd was able to trace all requested spans for the dev eth rpc, and show detailed breakdown of each rpc call
https://app.datadoghq.com/apm/traces?query=env%3Abodhi-dev&cols=core_service%2Ccore_resource_name%2Clog_duration%2Clog_http.method%2Clog_http.status_code&graphType=flamegraph&historicalData=true&messageDisplay=inline&query_translation_version=v0&shouldShowLegend=true&sort=time&spanID=4417068852833600411&spanType=all&timeHint=1696325305847&trace=AgAAAYr03gX3rwXWiQAAAAAAAAAYAAAAAEFZcjAzaHpRQUFBaEV2OElGR3c3cS1BdQAAACQAAAAAMDE4YWY0ZGUtMDVmNy00MjZlLWJlMzItNjhlMDg0YzQ2N2Ux&traceID=3377937921660487703&start=1696238987315&end=1696325387315&paused=false