Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for cache capacity #1054

Merged
merged 1 commit into from
Nov 12, 2024
Merged

add option for cache capacity #1054

merged 1 commit into from
Nov 12, 2024

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Nov 12, 2024

Change

latest pjs adds a config to control it's cache size, so let's give it one more chance.

hopefully fix #1050

In general I still think we should avoid building low level stuff ourselves (if possible), since it's very hard to make sure it works precisely. By adding 2 simple tests, we can already found the storage query we have been using for a long time actually returns wrong result, just happened to not affect our use case (as far as we know).

Test

all tests still pass

@shunjizhan shunjizhan marked this pull request as ready for review November 12, 2024 06:44
@shunjizhan shunjizhan merged commit e669650 into master Nov 12, 2024
14 checks passed
@shunjizhan shunjizhan deleted the add-cache-siz branch November 12, 2024 15:53
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (ce8fd1d) to head (febbf1b).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   74.51%   78.06%   +3.55%     
==========================================
  Files          55       55              
  Lines        3178     2722     -456     
  Branches      808      617     -191     
==========================================
- Hits         2368     2125     -243     
+ Misses        786      584     -202     
+ Partials       24       13      -11     
Files with missing lines Coverage Δ
packages/eth-providers/src/rpc-provider.ts 100.00% <100.00%> (ø)
packages/eth-rpc-adapter/src/index.ts 82.14% <ø> (ø)
packages/eth-rpc-adapter/src/utils/utils.ts 82.35% <100.00%> (+1.10%) ⬆️
packages/eth-rpc-adapter/src/wrapped-provider.ts 94.73% <100.00%> (ø)

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript heap out of memory on v2.9.1
2 participants