Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
latest pjs adds a config to control it's cache size, so let's give it one more chance.
hopefully fix #1050
In general I still think we should avoid building low level stuff ourselves (if possible), since it's very hard to make sure it works precisely. By adding 2 simple tests, we can already found the storage query we have been using for a long time actually returns wrong result, just happened to not affect our use case (as far as we know).
Test
all tests still pass