Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth rpc adapter tests #1032

Merged
merged 23 commits into from
Oct 10, 2024
Merged

eth rpc adapter tests #1032

merged 23 commits into from
Oct 10, 2024

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Sep 30, 2024

Change

  • updated all eth rpc tests to modular and self dependent tests, so it won't need to depend on deterministic setup, and becomes more flexible
  • updated CI to retry twice in case of network issue or flakiness
  • updated getFilterChanges so that if all target logs are in cache, it won't throw subql error, similar to getlogs. Also fixed a bug that get logs from cache did not apply topics filter

fix #1018

Test

all tests passed

Todo

#1033

@shunjizhan shunjizhan marked this pull request as ready for review October 10, 2024 08:05
@shunjizhan shunjizhan merged commit e2435dd into master Oct 10, 2024
13 of 14 checks passed
@shunjizhan shunjizhan deleted the eth-rpc-tests branch October 10, 2024 08:05
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.86%. Comparing base (29e56bb) to head (53fc83d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/eth-providers/src/base-provider.ts 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   62.14%   69.86%   +7.72%     
==========================================
  Files          56       56              
  Lines        4018     4019       +1     
  Branches     1028     1009      -19     
==========================================
+ Hits         2497     2808     +311     
+ Misses       1513     1195     -318     
- Partials        8       16       +8     
Files with missing lines Coverage Δ
packages/eth-providers/src/base-provider.ts 68.37% <0.00%> (+8.69%) ⬆️

... and 16 files with indirect coverage changes

@shunjizhan shunjizhan mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant