Qt6 Feature - Fix issues with Python 3.11 and PySide6 compilation on Windows #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedrik-fuoco-adsk
force-pushed
the
qt6-fix-issue-with-python
branch
from
ef3bc75 to
f1581fc
Compare
…ions Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
force-pushed
the
qt6-fix-issue-with-python
branch
from
f1581fc to
a28c14e
Compare
Signed-off-by: Cédrik Fuoco <[email protected]>
Signed-off-by: Cédrik Fuoco <[email protected]>
eloisebrosseau
approved these changes
Dec 9, 2024
cedrik-fuoco-adsk
merged commit 76e4fc3
into
AcademySoftwareFoundation:feature/qt6
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt6 Feature - Fix issues with Python
Linked issues
#367
Describe the reason for the change.
I created two functions to do the install step of Python. One for Python 3.10 (VFX2023) and one for Python 3.11 (VFX2024). I think it will be easier to maintain and remove later on. The difference was only for Windows, but both functions contains the code for all platforms.
Since Python 3.11, the
PLATLIBDIRdirectory was renamed toDLLsinstead oflib. You can changed it by modifying the Visual studio project file, but I found some place in the Python source code that was hardcoded toDLLs. I opted to keepDLLsand copy that over to the OpenRV's stage directory. It does not change anything functionally because the Python executable is looking for the DLLs library automatically.The changes above also fixes the issue with PySide6 compilation on Windows.
Describe what you have tested and on which operating system.
Windows
If possible, provide screenshots.
stage directory:
