Enable first frame to start at 0 #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
eloisebrosseau
force-pushed
the
off-by-one-frame
branch
from
34d0dc5 to
9a0fbbe
Compare
| static_cast<double>(m_avFormatContext->start_time) / static_cast<double>(AV_TIME_BASE))); | ||
| if (evStartFrameAtOne.getValue()) | ||
| { | ||
| firstFrame = max(int64_t(m_formatStartFrame), int64_t(1)); |
There was a problem hiding this comment.
Correct me if I am wrong but the m_formatStartFrame is no longer initialized right ? (with or without the new env var)
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
off-by-one-frame
branch
from
9a0fbbe to
521658f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable first frame to start at 0
Summarize your change.
If there is no timecode, the first frame will be 0 or the value calculated from the
start_timefield of the AVFormatContext. The offset is also adjusted to be at least 0 to prevent it from being negative.Describe the reason for the change.
In RV, if the media has no timecode, the first frame was being set to 1 if the
start_timefield of the AVFormatContext is 0. However, this was preventing the frame to be set to 0 to match the timeline of the Review App. The offset was also being set to a negative value when the first frame was set to 0.Describe what you have tested and on which operating system.
I manually tested a few movie files with different timecode and without any in RV with and without Live Review on MacOS.
Add a list of changes, and note any that might need special attention during the review.