Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement teardown action #51

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement teardown action #51

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ffe861b
Update action.yaml
stevefan1999-personal Dec 4, 2023
73cc0bb
Update action.yaml
stevefan1999-personal Dec 4, 2023
bd92cb2
Update run.sh
stevefan1999-personal Dec 4, 2023
81f4c0a
Update run.sh
stevefan1999-personal Dec 4, 2023
c47a901
Update action.yaml
stevefan1999-personal Dec 4, 2023
1d20158
Update action.yaml
stevefan1999-personal Dec 4, 2023
031b06b
Update run.sh
stevefan1999-personal Dec 4, 2023
7e18408
Update action.yaml
stevefan1999-personal Dec 4, 2023
e068df7
Update run.sh
stevefan1999-personal Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,12 @@ inputs:
runs:
using: composite
steps:
- id: main
shell: bash
run: ${{ github.action_path }}/run.sh deploy
- uses: gacts/run-and-post-run@v1
with:
run: |
${{ github.action_path }}/run.sh deploy
post: |
${{ github.action_path }}/run.sh teardown
Comment on lines +36 to +41
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that this would be an unnecessary way to run teardown over and over again in VM-based workflows. Could it be done differently?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think you shouldn't assume it will be VM based since you can run act locally -- given you just have Docker access, and act pretty much replicates 60% of GHA to let you run it locally so that you can test the workflow before it goes live on master.

env:
CLUSTER_NAME: ${{ inputs.cluster-name }}
ARGS: ${{ inputs.args }}
Expand Down
19 changes: 19 additions & 0 deletions run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,22 @@ deploy(){
wait_for_nodes
}

teardown(){
local name=${CLUSTER_NAME}
local arguments=${ARGS:-}
local k3dVersion=${K3D_VERSION:-${DEFAULT_K3D_VERSION}}

if [[ -z "${CLUSTER_NAME}" ]]; then
panic "CLUSTER_NAME must be set"
fi

echo -e "${YELLOW}Downloading ${CYAN}k3d@${k3dVersion} ${NC}see: ${K3D_URL}"
curl --silent --fail ${K3D_URL} | TAG=${k3dVersion} bash

echo -e "\existing_network${YELLOW}Teardown cluster ${CYAN}$name ${NC}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there is a need to re-download the k3d binary that is already there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least for some reason it was needed for https://github.com/nektos/act

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mentioned kind action in a related issue. Teardown also does not install kind again.

eval "k3d cluster delete $name"
}

# waits until all nodes are ready
wait_for_nodes(){
echo -e "${YELLOW}wait until all agents are ready${NC}"
Expand Down Expand Up @@ -121,6 +137,9 @@ case "$1" in
"deploy")
deploy
;;
"teardown")
teardown
;;
# "<put new command here>")
# command_handler
# ;;
Expand Down