Update UG and README #461
Merged
Update UG and README #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannagwan
added
priority.High
|
Deploy preview for notably-app ready! Built with commit 877b5bd |
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=========================================
Coverage 67.35% 67.35%
Complexity 591 591
=========================================
Files 100 100
Lines 2359 2359
Branches 227 227
=========================================
Hits 1589 1589
Misses 693 693
Partials 77 77 Continue to review full report at Codecov.
|
|
Deploy preview for notably-app ready! Built with commit 53de00d |
kevinputera
approved these changes
Apr 12, 2020
There was a problem hiding this comment.
@johannagwan thanks for the initiative! I have left some comments, what do you think? Otherwise, LTGM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
Changes include:
export to PDFpartBODYpart and make necessary changessymbolsto title naming restrictions, fix typo inRelativePathsymbolsto title naming restrictions, TODO: update figma diagram to remove the body (can someone help do this?)Format, will leave the more detailed changes for section 3.5.1 to @HemanshuGandhi (as stated in Notably v1.4 Deliverables (By 13-04) #380 )TABtoENTER, addcoming in v2.0for paths that include../newandeditformatCan someone help change in all the figma diagrams, from "Press tab to autofill" to "Press enter to autofill"? @HemanshuGandhi @ljiazh3ng @firzanarmani @kevinputera