Add Title and Body Displays to Block Content View #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemanshuGandhi
added
priority.High
|
Deploy preview for notably-app ready! Built with commit 4609425 |
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
============================================
- Coverage 67.38% 66.90% -0.49%
Complexity 593 593
============================================
Files 100 104 +4
Lines 2361 2378 +17
Branches 227 226 -1
============================================
Hits 1591 1591
- Misses 693 710 +17
Partials 77 77
Continue to review full report at Codecov.
|
kevinputera
reviewed
Apr 11, 2020
There was a problem hiding this comment.
Hey @HemanshuGandhi , looks great! Some comments:
- How'd you plan to accommodate for this (if the body contains an <h1>)?
- Do you have plans for including the path string beside the title (as drawn in the mockup)?
- Currently, the backend do not support editing a block's title. Should we just remove that functionality from
BlockContentEditView?
src/main/java/com/notably/view/blockcontent/BlockContentDisplayView.java
Outdated
Show resolved
Hide resolved
HemanshuGandhi
changed the title
kevinputera
approved these changes
Apr 12, 2020
src/main/java/com/notably/view/blockcontent/BlockContentDisplayView.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Hemanshu's deliverables in #380.