Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature block content edit view [View] #416

Merged
merged 20 commits into from
Apr 10, 2020
Merged

Feature block content edit view [View] #416

merged 20 commits into from
Apr 10, 2020

Conversation

HemanshuGandhi
Copy link

@HemanshuGandhi HemanshuGandhi commented Apr 8, 2020 •
edited
Loading

Part of Hemanshu's deliverables as in #380.

  • Adds a Block Content Edit View that can be opened via the "edit" command.
  • Block Content Edit View must be closed using the "ESC" key.
  • On closure, the new contents are passed to Logic, which then updates the Block's contents. (Autosave behavior).

@HemanshuGandhi HemanshuGandhi added status.Ongoing The issue is currently being worked on. Note: remove this label before closing an issue. priority.High Must do type.Enhancement An enhancement to an existing story labels Apr 8, 2020
@HemanshuGandhi HemanshuGandhi added this to the v1.4 milestone Apr 8, 2020
@HemanshuGandhi HemanshuGandhi self-assigned this Apr 8, 2020
@netlify
Copy link

netlify bot commented Apr 8, 2020 •
edited
Loading

Deploy preview for notably-app ready!

Built with commit 962adaa

https://deploy-preview-416--notably-app.netlify.com

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #416 into master will decrease coverage by 3.28%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #416      +/-   ##
============================================
- Coverage     68.70%   65.41%   -3.29%     
  Complexity      530      530              
============================================
  Files            97       97              
  Lines          2029     2131     +102     
  Branches        201      202       +1     
============================================
  Hits           1394     1394              
- Misses          556      658     +102     
  Partials         79       79
Impacted Files Coverage Δ Complexity Δ
...n/java/com/notably/logic/commands/EditCommand.java 25.00% <0.00%> (-8.34%) 1.00 <0.00> (ø)
src/main/java/com/notably/view/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/com/notably/view/blockcontent/BlockContent.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...bly/view/blockcontent/BlockContentDisplayView.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...otably/view/blockcontent/BlockContentEditView.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a9401...962adaa. Read the comment docs.

@HemanshuGandhi HemanshuGandhi marked this pull request as ready for review April 8, 2020 17:23
@kevinputera kevinputera requested review from ljiazh3ng and a team April 9, 2020 03:06
kevinputera
kevinputera approved these changes Apr 9, 2020
View reviewed changes
Copy link

@kevinputera kevinputera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @HemanshuGandhi are you going to add the title info and path info header to BlockContentDisplayView?

src/main/java/com/notably/view/MainWindow.java Show resolved Hide resolved
src/main/java/com/notably/view/blockcontent/BlockContentEditView.java Outdated Show resolved Hide resolved
kevinputera
kevinputera reviewed Apr 9, 2020
View reviewed changes
Copy link

@kevinputera kevinputera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments!

src/main/java/com/notably/logic/commands/EditCommand.java Outdated Show resolved Hide resolved
@HemanshuGandhi HemanshuGandhi force-pushed the feature-block-content-edit-view branch from 04e6d30 to 1855a38 Compare April 9, 2020 20:57
@HemanshuGandhi HemanshuGandhi force-pushed the feature-block-content-edit-view branch 2 times, most recently from 6f7d313 to 3f2659b Compare April 10, 2020 08:20
@HemanshuGandhi HemanshuGandhi merged commit 498bc28 into AY1920S2-CS2103T-W17-2:master Apr 10, 2020
@HemanshuGandhi HemanshuGandhi deleted the feature-block-content-edit-view branch April 10, 2020 08:24
@firzanarmani firzanarmani mentioned this pull request Apr 12, 2020
Closed
@firzanarmani firzanarmani linked an issue Apr 12, 2020 that may be closed by this pull request
[PE-D] Difficult to edit notes #343
Closed
This was referenced Apr 12, 2020
Closed
Closed
This was linked to issues Apr 12, 2020
[PE-D] Unable to have linebreak in body section of the note #360
Closed
[PE-D] Editing a note is equivalent to rewriting the whole note #363
Closed
This was referenced Apr 12, 2020
Closed
Closed
@firzanarmani firzanarmani linked an issue Apr 12, 2020 that may be closed by this pull request
[PE-D] Incorrect parsing for edit command #366
Closed
@firzanarmani firzanarmani mentioned this pull request Apr 12, 2020
Closed
@firzanarmani firzanarmani linked an issue Apr 12, 2020 that may be closed by this pull request
[PE-D] Not able to add in text in the body #374
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinputera kevinputera kevinputera approved these changes

@ljiazh3ng ljiazh3ng Awaiting requested review from ljiazh3ng

Assignees

@HemanshuGandhi HemanshuGandhi

Labels
priority.High Must do status.Ongoing The issue is currently being worked on. Note: remove this label before closing an issue. type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
v1.4
2 participants
@HemanshuGandhi @kevinputera