Updates to timestamp UI #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for avannotate-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camdendotlol
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Changes the display value in the
TimeInputcomponent to avoid confusion with converting partial inputs to actual timestamps; for example, previously if you tried to input the timestamp6:50, after the first two keystrokes the value would convert to1:05rather than0:65, meaning after the third keystroke you're left with a timestamp of10:50, which is unintended and confusing.Also removes the milliseconds from the player display, as their existence was leading to difficulty pasting values directly from the player into the annotation editor modal due to different levels of precision.
Relevant to issues #210, #167, and AVAnnotate/project-client#119.