Improve archive platform suffix resolution

[mjburling]

Closes #45.

This change set extends get_target_platform() functionality to include the separate get_arch() function. This now includes an extended map of (std::env::consts::OS, std::env::consts::ARCH) pairs that map to Go equivalents formatted vaguely as the following: ~"${runtime.GOOS}_${runtime.GOARCH}".

Pardon my Rust, but this seems to work and remains pretty consistent with your solution so far.

Feedback welcome! Thanks for your consideration!

[ASleepyCat]

Thanks for reporting the issue and creating a PR for it.

The only issues I have is that this drops support for other OSes like OpenBSD and Solaris, and that I'd rather return an error than panic.

It's fine if you don't address the first issue, since those other OSes aren't fully supported by Rust anyway. I prefer errors since that won't produce a stack trace to the user that probably won't mean anything to them.

Also the unit tests will need to be updated since you deleted get_arch().

[mjburling]

Thanks for reporting the issue and creating a PR for it.

The only issues I have is that this drops support for other OSes like OpenBSD and Solaris, and that I'd rather return an error than panic.

It's fine if you don't address the first issue, since those other OSes aren't fully supported by Rust anyway. I prefer errors since that won't produce a stack trace to the user that probably won't mean anything to them.

Whoops! I didn't mean to leave any users out in the cold! I've re-added support for freebsd, openbsd, and solaris–those are supported by tofu/terraform–there are 14 distinct supported combinations as of tofu/terraform ~> 1.6.

I see what you mean on the panic bit. Strictly speaking, there shouldn't be anything here from stopping users from running this application on say a combination of ("linux", "powerpc64"), but... maybe that is a meaningful place to panic? There's no upstream support for this platform, thus no archive (terraform|tofu)_x.y.z_linux_powerpc64.zip.

Also the unit tests will need to be updated since you deleted get_arch().

Very sloppy of me! I thought the build would fail by default if there were any unresolved/unreachable symbols. Seems the test scope gets slightly different treatment. I've elected to remove these instead... there's less to test and even less value in attempting to test it now.

[ASleepyCat]

I see what you mean on the panic bit. Strictly speaking, there shouldn't be anything here from stopping users from running this application on say a combination of ("linux", "powerpc64"), but... maybe that is a meaningful place to panic? There's no upstream support for this platform, thus no archive (terraform|tofu)_x.y.z_linux_powerpc64.zip.

That's fair, I came to the same realisation with all the other platforms being put back in now.

Very sloppy of me! I thought the build would fail by default if there were any unresolved/unreachable symbols. Seems the test scope gets slightly different treatment. I've elected to remove these instead... there's less to test and even less value in attempting to test it now.

Yeah, the test module isn't part of compilation unless you run cargo t. I'm fine with not having a bunch of unit tests for the function.

LGTM.