Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tarantula_added #242

Closed
wants to merge 1 commit into from
Closed

tarantula_added #242

wants to merge 1 commit into from

Conversation

ashraf04066
Copy link

Here, I have added Tarantula laws instead of Ochiai.

@andre15silva andre15silva mentioned this pull request May 24, 2023
Merged
@andre15silva
Copy link
Member

Hi @ashraf04066 ,

Thanks for the PR!

The reason why you only generate 1.0 is due to using ints and not doubles in your calculations. Thus, Java will round the division and return 1.0.

I am introducing a correct implementation of Tarantula in #243 , and I'm also changing the types to doubles to prevent other similar errors.
You can select it with the option --formula=TARANTULA through the cli, or by setting the formula option in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashraf04066 @andre15silva