[pauthabi64][aaelf64] Move PAuth GOT relocs out of private space #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovdan01
added a commit
to kovdan01/llvm-project
that referenced
this pull request
Dec 1, 2024
Apply change from the spec ARM-software/abi-aa#300
kovdan01
added a commit
to llvm/llvm-project
that referenced
this pull request
Dec 2, 2024
…ce (#118214) Apply change from the spec ARM-software/abi-aa#300
TIFitis
pushed a commit
to TIFitis/llvm-project
that referenced
this pull request
Dec 18, 2024
…ce (llvm#118214) Apply change from the spec ARM-software/abi-aa#300
|
I'm working on a rebase of this PR. |
In the initial draft relocations for signing GOT entries were defined in the private space reserved for experiments. It was not known if these relocations would be useful as if RELRO is supported the GOT does not need to be signed. There is now at least one user of the GOT signing relocations so we should move the relocations out of the private space and into the space reserved for the PAuthABI. This PR includes relocations added in ARM-software#295 Fixes: ARM-software#298
smithp35
force-pushed
the
renumber-pauth-relocs
branch
from
6b15b45 to
5ed7ee4
Compare
stuij
reviewed
Jan 10, 2025
pauthabielf64/pauthabielf64.rst
Outdated
| @@ -1117,80 +1120,80 @@ The GOT entries must be relocated by AUTH variant dynamic relocations. | |||
| +-------------+----------------------------------------+----------------------------------------+--------------------------+ | |||
| | ELF 64 Code | Name | Operation | Comment | | |||
| +=============+========================================+========================================+==========================+ | |||
| | 0x8110 | R\_AARCH64\_AUTH\_MOVW\_GOTOFF\_G0 | G(ENCD(GDAT(S))) - GOT | Set a MOV[NZ] immediate | | |||
| | 0x245 | R\_AARCH64\_AUTH\_MOVW\_GOTOFF\_G0 | G(ENCD(GDAT(S))) - GOT | Set a MOV[NZ] immediate | | |||
There was a problem hiding this comment.
Very much a nit, but for the sanity of people that cross reference aaelf64 and pauthabielf64 documentation, it'd be nice if the ELF code in this doc wasn't written in hex.
There was a problem hiding this comment.
I originally wrote it in hex as LLVM (only implementation of PAuthABI defines relocation numbers in hex so this made it easier to cross-check the implementation. Just thinking if it is worth writing both? For example 0x245 (581)
Add a decimal representation of the relocation code alongside the relocation code for easier cross-reference with AAELF64. The PAuthABI uses hex for the relocation codes as the only implementation LLVM uses hex in the relocation definitions. This makes it easier to cross-reference. Adding the decimal in parentheses satisfies both forms of cross-reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial draft relocations for signing GOT entries were
defined in the private space reserved for experiments. It was not
known if these relocations would be useful as if RELRO is supported
the GOT does not need to be signed. There is now at least one user
of the GOT signing relocations so we should move the relocations
out of the private space and into the space reserved for the
PAuthABI.
This PR includes relocations added in
#295
Fixes: #298