Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git instructions #43

Merged
merged 3 commits into from
May 17, 2024

Conversation

mgrover1
Copy link
Contributor

Update the git instructions to reflect new github tokens \

Closes #42

@mgrover1 mgrover1 requested a review from wgustafson May 17, 2024 17:28
Copy link

github-actions bot commented May 17, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: d88597f
✅ Deployment Preview URL: https://ARM-Development.github.io/arm-summer-school-2024/_preview/43

@mgrover1
Copy link
Contributor Author

@wgustafson - can you give this a read over to make sure it addresses the issue?

@wgustafson
Copy link
Collaborator

@mgrover1 , I was not able to get the fine-grain tokens to work when I tried yesterday. I could only get the classic tokens to permit me to push changes back to the cloud version of the repository. Some of the confusion might be in the instructions to select repo, admin:org, and workflow for the permissions tied to the token. This is a classic mindset, and I think the fine-grain ones work differently? I don't know the details enough to say.

The easy way out is to change the instructions to have folks use classic instead of fine-grain. You edit directs folks to fine-grain. If I just missed something, then fine-grain may work, but the instructions will need to be modified to whatever is needed to make it work.

@mgrover1
Copy link
Contributor Author

Ahhh okay - I thought you were suggesting to use fine-grain instead of the classic one! I can change to the general one.

@mgrover1
Copy link
Contributor Author

@wgustafson this should clarify it more!

Also, @jrobrien91 - this fixes the incorrect repo name as well.

@mgrover1 mgrover1 merged commit a88a9d2 into ARM-Development:main May 17, 2024
1 of 2 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that a "classic" token is needed for github
2 participants