Persistence test ignore range #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
…because of hardware/VM./
|
@kenkehoe Looks like we are getting an assertion error still. |
|
OK I will look into this and find a solution for the hardware differences. |
… across hardware.
|
Hmm, the windows test failing is interesting, wonder if there was some sort of change to actions for windows builds? |
|
Error is unrelated to the PR, windows builds are broken for Py-ART as well. |
zssherman
force-pushed
the
persistence_test_ignore_range
branch
from
448daa5 to
61ab85c
Compare
|
Once the non windows tests pass, I will work on CI fixes in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the persistence test to have a new keyword to allow ignoring the results of the test when the data values fall within a range of values. There are known times when values will fail the persistence test but there is not issue. e.g. weather station during a rain event has RH at 100%.