ADD: calculate_percentage function. #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the hashes aren't matching... |
|
Rerunning one more time with the PR now for arm-test-data |
AdamTheisen
reviewed
Mar 28, 2024
There was a problem hiding this comment.
@zssherman this looks good! The only thing I can think of is adding in an example that would show how to use the percentages returned to create a pie chart. Thoughts?
|
@AdamTheisen Yeah I can do that! It's a one liner that I can add in the example. Once the piechart function is actually added, i can swap out the one line in the example with the new function |
|
@AdamTheisen Example has been added. |
|
Once this is approved, we can merge and I'll rerun Bobby's PR |
AdamTheisen
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows the user (ex: aerosol data) to provide fields and calculate the percentage of that field in a volume. The code also checks for invalid numbers if the user provides a threshold. User can also provided a specific time, a range of times, or get an mean of the whole dataset.
This function will eventually be used for the PieChart function I'm working on.