Unit conversion warning #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
zssherman
reviewed
Jan 26, 2024
| verbose : boolean | ||
| Option to print statement when an attempted conversion fails. Set to False | ||
| as default because many units strings are not udunits complient and when | ||
| trying to convert all varialbes of a type of units (eg temperature) the code |
There was a problem hiding this comment.
complient to compliant and varialbes to variables
zssherman
reviewed
Jan 26, 2024
tests/utils/test_data_utils.py
Outdated
| @@ -93,10 +95,13 @@ def test_convert_units(): | |||
| data = act.utils.data_utils.convert_units(r_data, 'K', 'C') | |||
| assert np.ceil(data[0]) == 12 | |||
|
|
|||
| try: | |||
| # try: | |||
| # ds.utils.change_units() | |||
There was a problem hiding this comment.
Can we remove the commented out code?
|
@kenkehoe Thanks for the PR! I added a few comments |
|
@zssherman I removed the old code and submitted a job to run. I assume you can make the failing part of this process more better? I don't think it's something on my end. |
|
@kenkehoe Thanks for the changes! Yeah it was a stalled test. Should be rerunning now |
AdamTheisen
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds keywords to the convert_units method to notify user when the conversion fail. Because of how the method can loop through all the variables in the Dataset we don't want to print or raise exceptions when a conversion fails. This adds options the user can implement. I tried to use warnings but they didn't work so it's a print statement.