Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove stamen for v2.0. #756

Merged
merged 1 commit into from
Nov 29, 2023
Merged

MNT: Remove stamen for v2.0. #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions act/plotting/geodisplay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def geoplot(
img_tile=None,
img_tile_args={},
tile=8,
stamen='terrain-background',
cartopy_feature=None,
cmap='rainbow',
text=None,
Expand Down Expand Up @@ -210,16 +209,9 @@ def geoplot(
else:
plt.title(title)

if stamen and img_tile is None:
tiler = img_tiles.Stamen(stamen)
if img_tile is not None:
tiler = getattr(img_tiles, img_tile)(**img_tile_args)
ax.add_image(tiler, tile)
warnings.warn(
"Stamen is deprecated in Cartopy and in future versions of ACT, "
"please use img_tile to specify the image background. ")
else:
if img_tile is not None:
tiler = getattr(img_tiles, img_tile)(**img_tile_args)
ax.add_image(tiler, tile)

colorbar_map = None
if cmap is not None:
Expand Down
1 change: 0 additions & 1 deletion act/tests/test_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,6 @@ def test_geoplot():
],
text={'Ponca City': [-97.0725, 36.7125]},
img_tile=None,
stamen=None,
)
try:
return geodisplay.fig
Expand Down
Loading