Pint update to stop warning #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
zssherman
approved these changes
Nov 3, 2023
|
Closing and reopening to run tests as github was down |
AdamTheisen
approved these changes
Nov 7, 2023
|
Looks good once the final test passes |
|
@AdamTheisen what are the chances of getting a release with this update? We are getting a warning and my attempts to stop sending alerts to us about the warning are not working. If we make this update I can stop those warnings sending us emails. |
|
@kenkehoe I can get one out today! |
|
@kenkehoe The github and pypi release is out, just waiting on conda-forge to pick up the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pint library is warning of redefining units. This update correctly adds the desired units and stops redefining units. Also commented out some return statements in plotting testing to stop warnings of future errors.