Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO Changes for V2.0.0 #739

Merged
merged 8 commits into from
Nov 30, 2023
Merged

IO Changes for V2.0.0 #739

merged 8 commits into from
Nov 30, 2023

Conversation

AdamTheisen
Copy link
Collaborator

@AdamTheisen AdamTheisen commented Oct 13, 2023

Major changes for 2.0.0 include the renaming of armfiles.read_netcdf to arm.read_arm_netcdf and csvfiles.py to csv.py

  • Closes Consistent IO Names for V2.0.0 #730
  • Tests added
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AdamTheisen
Copy link
Collaborator Author

@zssherman @rcjackson @mgrover1 we'll have to figure out how to do this with the PySP2 dependency on ACT

@zssherman zssherman merged commit c985def into ARM-DOE:main Nov 30, 2023
16 checks passed
@AdamTheisen AdamTheisen deleted the io_v2 branch January 31, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent IO Names for V2.0.0
2 participants