Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: IO Warning fixes. #719

Merged
merged 6 commits into from
Sep 29, 2023
Merged

FIX: IO Warning fixes. #719

merged 6 commits into from
Sep 29, 2023

Conversation

zssherman
Copy link
Collaborator

@zssherman zssherman commented Sep 27, 2023 •
edited
Loading

Fixes to remove warnings in IO. All warnings left in IO are either dependency warnings outside our control or are 2.0 deprecation warnings.

  • Closes UserWarning for Time #704
  • Documentation reflects changes
  • PEP8 Standards or use of linter
  • Xarray Dataset or DataArray variable naming follows 'ds' or 'da' naming

@zssherman zssherman closed this Sep 28, 2023
@zssherman zssherman reopened this Sep 28, 2023
mgrover1
mgrover1 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @zssherman

@mgrover1 mgrover1 merged commit cf6ee7a into ARM-DOE:main Sep 29, 2023
@zssherman zssherman deleted the warning_fixes branch December 11, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@AdamTheisen AdamTheisen Awaiting requested review from AdamTheisen AdamTheisen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserWarning for Time
2 participants
@zssherman @mgrover1