Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial conversion to Net 8.0 #9504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zur003
Copy link
Contributor

@zur003 zur003 commented Dec 5, 2024

Working on #9503

This version compiles, but doesn't include package updates. Those are yet to come.

@zur003
Copy link
Contributor Author

zur003 commented Dec 5, 2024

It looks like the docker image that Jenkins uses to build ApsimX will need to be update to use .Net 8.0 before this will work.

@par456
Copy link
Collaborator

par456 commented Dec 6, 2024

Looking at the docker scripts for this, it's based on a 6.0 image, so it'll be a pain to add both 6 and 8 in at the same time, and if we change it to net 8, then all the other PRs won't run until this is merged. We could potentially install 8 as part of the build process, but that'll also blowout the build times while it's active like that.

Considering it's halfway through a friday, we might need to sit on this PR for another day where we do a planned switch across to 8 and get the conversion done in one jump and have time for all the followup testing it'll require.

Thanks for getting a start on this Eric, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants