Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grain nitrogen concentrogen #8855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

byzheng
Copy link
Contributor

@byzheng byzheng commented Apr 18, 2024

working on #3605

Test method to calculate minimum nitrogen concentration of grain in #3606. Some improvement is observed for Australian wheat trials. Test for other crops.

@BrianCollinss
Copy link
Member

BrianCollinss commented Apr 18, 2024

This might be irrelevant to this issue. Currently accepted stats are indicators of model performance using a combination of parameters (some being genotypic, e.g., phenology) that were chosen and/or calibrated based on some observations. When there is a major change (like this) in the way the model handles biomass and N flow and deposition, don't we need to recalibrate the other parts of the models before we decide that any improvement observed is not just the model behaving randomly? In other words, if for example biomass was simulated reasonably well before a change, and now we are making this change, should we also make some changes in other parameters that govern biomass components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants