Allow the "@" character to be used in Report aliases (along with the … #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…current alphanumeric, "_" and "." characters).
|
@hut104 - Why would aliasing with the "." character cause any more confusion than is possible without it? I can easily alias [Wheat].Leaf.LAI to RootingDepth, which would be even more confusing than your example. |
|
People may start to think that there is an LAI member on Wheat. I guess it comes back to the fact that "." means something already. It may become really confusing when debugging things if it is not clear what is real and what is alias. At least the "_" character is not currently used in APSIM for anything (It took us years to get rid of it to clean things up).
I think I also suggested this becaues I know that we have moved away from this several times in the past for these reasons.
…________________________________
From: Eric Zurcher <[email protected]>
Sent: Tuesday, 26 May 2020 9:24 AM
To: APSIMInitiative/ApsimX <[email protected]>
Cc: Huth, Neil (A&F, Toowoomba) <[email protected]>; Mention <[email protected]>
Subject: Re: [APSIMInitiative/ApsimX] Allow the "@" character to be used in Report aliases (along with the … (#5201)
@hut104<https://github.com/hut104> - Why would aliasing with the "." character cause any more confusion than is possible without it? I can easily alias [Wheat].Leaf.LAI to RootingDepth, which would be even more confusing than your example.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5201 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2UVWTMGF4IBL7YA5TOGXLRTL425ANCNFSM4NJG2KPA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…current alphanumeric, "_" and "." characters). Working on #4080