Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Fixed quaternion unit tests #18

Merged
merged 1 commit into from
Mar 13, 2018
Merged

fix(tests): Fixed quaternion unit tests #18

merged 1 commit into from
Mar 13, 2018

Conversation

reinzor
Copy link
Contributor

@reinzor reinzor commented Feb 21, 2018

Fixes #16

@reinzor
Copy link
Contributor Author

reinzor commented Mar 2, 2018

Ping

@remod
Copy link
Member

remod commented Mar 13, 2018 •
edited
Loading

Thanks, lgtm, @pfankhauser ?

@pfankhauser
Copy link
Member

Thanks @reinzor! I'd be happy to merge, could you quickly explain why you did this change? Did the unit tests not work for you?

@reinzor
Copy link
Contributor Author

reinzor commented Mar 13, 2018

The unit tests were indeed failing due to the quaternion accuracy.

@pfankhauser
Copy link
Member

Ok, not for us, weird. Thanks!

@pfankhauser pfankhauser merged commit 2e692ea into ANYbotics:master Mar 13, 2018
@reinzor
Copy link
Contributor Author

reinzor commented Mar 13, 2018

I referred to the wrong issue, should close #14

@reinzor reinzor deleted the fix/quaternion_conversion_tests branch March 13, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reinzor @remod @pfankhauser