Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test dependency to on rosbag default plugins #491

Merged

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Nov 28, 2024

Purpose

Fix issue in CI with rosbag throwing exception in the CI test environment because it fails to initialize from missing the sqlite plugin

Tests Performed

None, this is build farm only. in order to reproduce this, I have set up a new CI job in #492.

I then rebased 492 on top of this PR, and will see if it's resolved.

Issue

Closes #490

@Ryanf55 Ryanf55 added the ros2 Affects ROS 2 label Nov 28, 2024
@Ryanf55 Ryanf55 requested a review from wep21 November 28, 2024 17:44
@Ryanf55 Ryanf55 mentioned this pull request Nov 28, 2024
@Ryanf55 Ryanf55 merged commit 73d9427 into ANYbotics:rolling Nov 29, 2024
2 checks passed
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 29, 2024

@Mergifyio backport jazzy

Copy link

mergify bot commented Nov 29, 2024

backport jazzy

✅ Backports have been created

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 29, 2024

@Mergifyio backport iron

Copy link

mergify bot commented Nov 29, 2024

backport iron

✅ Backports have been created

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Nov 29, 2024

@Mergifyio backport humble

Copy link

mergify bot commented Nov 29, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)
mergify bot pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)
@Ryanf55 Ryanf55 deleted the 490-rosbag-no-storage-type-id-sqlite3 branch November 29, 2024 15:28
Ryanf55 added a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)

Co-authored-by: Ryan <[email protected]>
Ryanf55 added a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)

Co-authored-by: Ryan <[email protected]>
Ryanf55 added a commit that referenced this pull request Nov 29, 2024
Signed-off-by: Ryan Friedman <[email protected]>
(cherry picked from commit 73d9427)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants