build: treat several build issues on rolling #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wep21
commented
May 23, 2024
•
wep21
commented
- skip installing octomap server because it is still not available on rolling.
- ignore compiler warnings due to gcc 13 bug
Signed-off-by: wep21 <[email protected]>
|
Looks like some new compile errors are cropping up in rolling. Do you think you would have time to get those fixed so CI passes too, or not? |
Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
ci-temp-skip-octomap-server
branch
from
7f7b07b
to
ee49bf4
Compare
wep21
changed the title
wep21
changed the title
|
I adopted the change from this PR to suppress compiler warning due to gcc13 bug. |
|
I cherry-picked the change to check if rolling ci passes. |
|
Nice find. Looks like theres more issues. Were you hoping to merge as-is and fix the rest later? I don't yet have a jazzy environment configured yet. |
Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
ci-temp-skip-octomap-server
branch
from
b9f6074
to
78dac34
Compare
Signed-off-by: wep21 <[email protected]>
wep21
force-pushed
the
ci-temp-skip-octomap-server
branch
from
78dac34
to
d576a7b
Compare
|
Additionally, I added 2 changes as below.
|
Signed-off-by: wep21 <[email protected]>
Ryanf55
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.