pybind11: use properties

AMYPAD · Feb 22, 2024 · b45074d · b45074d
1 parent 4db216a
commit b45074d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/cuvec/include/cuvec_pybind11.cuh b/cuvec/include/cuvec_pybind11.cuh
@@ -29,8 +29,9 @@ PYBIND11_MAKE_OPAQUE(NDCuVec<double>);
   pybind11::class_<NDCuVec<T>>(m, PYBIND11_TOSTRING(NDCuVec_##typechar))                          \
       .def(pybind11::init<>())                                                                    \
       .def(pybind11::init<std::vector<size_t>>())                                                 \
-      .def("reshape", &NDCuVec<T>::reshape)                                                       \
-      .def("shape", [](const NDCuVec<T> &v) { return v.shape; })                                  \
-      .def("address", [](NDCuVec<T> &v) { return (size_t)v.vec.data(); })
+      .def_property(                                                                              \
+          "shape", [](const NDCuVec<T> *v) { return &(v->shape); }, &NDCuVec<T>::reshape)         \
+      .def_property_readonly("address",                                                           \
+                             [](const NDCuVec<T> *v) { return (size_t)v->vec.data(); })
 
 #endif // _CUVEC_PYBIND11_H_
diff --git a/cuvec/pybind11.py b/cuvec/pybind11.py
@@ -44,16 +44,16 @@ def __init__(self, typechar: str, shape: Shape, cuvec=None):
 
     @property
     def shape(self) -> tuple:
-        return tuple(self.cuvec.shape())
+        return tuple(self.cuvec.shape)
 
     @shape.setter
     def shape(self, shape: Shape):
         shape = cu.Shape(shape if isinstance(shape, Sequence) else (shape,))
-        self.cuvec.reshape(shape)
+        self.cuvec.shape = shape
 
     @property
     def address(self) -> int:
-        return self.cuvec.address()
+        return self.cuvec.address
 
 
 Pybind11Vector.vec_types = {np.dtype(c): partial(Pybind11Vector, c) for c in typecodes}