speciesNames for Manifold EOS #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this moving the definitions to the header. The only thing is making sure the linkers don't hit "multiple definition" type of errors. |
|
The multiple definition error is resolved by marking the template specializations as |
baperry2
force-pushed
the
specnames
branch
2 times, most recently
from
0ea1c12 to
fe205d8
Compare
…er; improve speciesNames function for manifold
marchdf
approved these changes
Dec 4, 2024
terencelehmann
pushed a commit
to ITV-RWTH/PelePhysics
that referenced
this pull request
Dec 10, 2024
* simplify templated functions in EOS.cpp * rearrange template specializations in EOS.cpp so they are all in header; improve speciesNames function for manifold * SYCL ifdef for manifold speciesnames * pass host eosparm to reactors * ignitionDelay: remove one invalid call for manifold eos * fix dumb bug * clang-tidy unused arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These get read from the table metadata rather than specified at compile time. Therefore, to define them, eosparm needs to be passed to the appropriate function. The implementation should be backward compatible and only require the modified call signature when using Manifold EOS.
This PR also modifies the out-of-class EOS function templates work to eliminate
EOS.cppand reduce redundant code, but perhaps is less readable? Open to suggestion on this.