Used Cantera reaction rate coefficient units #416
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to #318 for computing the production rates for elementary reactions with FORD reactions
The reaction rate coefficients appearing as
ctuc
inceptr/production.py
are computed directly from Cantera, except for Three-Body reactions, which are made to work according to Cantera's legacy behaviour as discussed in #323.These changes are reflected in the
comp_qfqr
,productionRate
and theproductionRate_Light
methods of the correspondingmechanism.H
files.This fix should immediately work for FORD reactions when not using the analytic Jacobian.