-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition verification for external sources #443
Composition verification for external sources #443
Conversation
Documenting the problem with ubuntu-24.04 EB-ON CI test: Data read in during macOS test: Data read in during the ubuntu test (4 processors each adding to tempExtremas): |
Let's see if MPI works better if we step ubuntu back #446 until I figure what happened to MPI in the latest image. |
So we can use |
@jrood-nrel, any idea why there are expected tests for CPU-CMake ubuntu-24.04 in the testing queue? |
Those have to be updated after this is merged. It is because the required tests were renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just the minor change for ignore-unused.
ext_src_arr[box_no](i, j, k, FIRSTODE + n) += src; | ||
} | ||
// Ignore time as it is only used if composition_test = 1 | ||
amrex::ignore_unused(time); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ignore unused and the one below shouldn't be needed. ignore-Unused should only be needed when certain variables are excluded by compile time macros, not runtime conditionals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying. I made the update and merged the most recent branch.
This PR adds a test to the$\rho$ and species mass fractions $Y_m$ . The initial mass fractions are set to $Y_{CO2} = 0.15$ , $Y_{N2} = 0.25$ , and $Y_{AR} = 0.6$ .
EB_ODEQty
regression test, namelycomposition-test-2d.inp
, which verifies the implementation of user-defined external sources for densityAfter$t_s$ seconds, CO2 is added at a rate $S_{ext,\rho Y_{CO2}}$ , which also causes the density to increase at a rate of $S_{ext,\rho} = S_{ext,\rho Y_{CO2}}$ .
The results can be plotted against the analytical solutions in
plot-comps.py
(see figure below) and tested in the CI viatest.py
, where errors must be less than a specified maximum error threshold. This was done by addingadd_test_rt
toCMakeLists
, which runs any python script calledtest.py
in the specified case directory.Additionally, this PR fixes a minor bug in
problem_modify_ext_sources
, where time is passed in viaa_timestamp_old
instead ofa_timestamp_new
due to the explicit treatment of the external source terms.