Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VODE_MAXORD a runtime parameter #1644

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from
Draft

Make VODE_MAXORD a runtime parameter #1644

wants to merge 4 commits into from

Conversation

psharda
Copy link
Collaborator

@psharda psharda commented Aug 27, 2024

No description provided.

@psharda psharda requested a review from zingale August 27, 2024 11:41
@psharda psharda marked this pull request as draft August 27, 2024 11:47
@zingale
Copy link
Member

zingale commented Aug 27, 2024

this should be a compile-time parameter, not a runtime parameter. We allocate memory based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale Awaiting requested review from zingale

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement integrator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psharda @zingale @BenWibking