Update test_rhs/inputs_ecsn to fully exercise tabular rates #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add it to the test_rhs CI workflow. These inputs cover all the different interpolation/extrapolation cases in the tabular rate evaluation code. This should cause a failure in the nightly regression tests, and the benchmark will need to be updated on groot.
yut23
changed the title
|
I will approve this request, but the update on groot may need to be updated. |
aisclark91
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add it to the test_rhs CI workflow.
These inputs cover all the different interpolation/extrapolation cases in the tabular rate evaluation code.
This should cause a failure in the nightly regression tests, and the benchmark will need to be updated on groot.