Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass in the correct dloga when doing tracing #2994

Merged
merged 9 commits into from
Nov 17, 2024

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented Nov 14, 2024

PR summary

computes dloga in y-direction and pass in the correct dloga for the corresponding dir. This was missed in pr #2964 .

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3 zhichen3 marked this pull request as ready for review November 14, 2024 06:08
@zingale
Copy link
Member

zingale commented Nov 14, 2024

does this fix any issues? or it is just safely zeroing out dlogA for non-curvilinear geometries?

@zhichen3
Copy link
Collaborator Author

this fixes the issue where we only computed and used dloga in the 0-direction, so we were using dlogaX in both x- and y- normal direction when we do the tracing with the primitive geometric terms for rho, pres and rhoe. Now we compute dloga in both 0 and 1 direction and pass in the corresponding dloga.

@zingale
Copy link
Member

zingale commented Nov 14, 2024

oh right. I think I was looking at a commit and now the full changes.

@zingale
Copy link
Member

zingale commented Nov 14, 2024

there's roundoff diffs for one problem:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-11-14-001/bwp.html

@zingale zingale merged commit 2fb7228 into AMReX-Astro:development Nov 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants