Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a check on whether the outer boundary is open in gravity #2833

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix a check on whether the outer boundary is open in gravity #2833

merged 2 commits into from
Apr 26, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 26, 2024

we were testing physbc_lo[dim] != amrex::PhysBCType::interior when it should be physbc_hi[dim]

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
fix a check on whether the outer boundary is open in gravity
6053b3e 
we were testing physbc_lo[dim] != amrex::PhysBCType::interior
when it should be physbc_hi[dim]
@zingale zingale merged commit 9338c82 into AMReX-Astro:development Apr 26, 2024
25 checks passed
@zingale zingale deleted the fix_gravity_lo_check branch April 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23