Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a better 3D inputs file for massivestar #2815

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 5, 2024

this uses jumps by 4x and has better refinement tagging

this also uses the reaction retry mechanism and a very small
ode_max_steps to force a retry with a different Jacobian if things
are hard

Finally, it disables subcycling

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

this uses jumps by 4x and has better refinement tagging
this also uses the reaction retry mechanism and a very small
ode_max_steps to force a retry with a different Jacobian if things
are hard
@zingale zingale merged commit bcbd7f9 into AMReX-Astro:development Apr 7, 2024
25 checks passed
@zingale zingale deleted the massive_star_3d_again branch April 7, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants