Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ggravity does not need to be static. #2791

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Ggravity does not need to be static. #2791

merged 1 commit into from
Mar 19, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 19, 2024

Compute it as const -- we always use C::Gconst

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Ggravity does not need to be static.
5e61296 
Compute it as const -- we always use C::Gconst
@zingale zingale merged commit bfce27d into AMReX-Astro:development Mar 19, 2024
22 checks passed
@zingale zingale deleted the ggravity branch March 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz